The code review part resonates a lot with me. Nothing scares me away more quickly than a pull request with no description, tests failing (or worse, no tests), no ticket/issue ID linked to it, etc.
The person opening the pull request is shifting the burden onto you to figure out what needs to be done and why. I believe this isn’t done in bad faith; it’s a matter of educating coworkers about boundaries for effective collaboration.
My principle is simple: I wouldn’t ask you to do something I wouldn’t do myself.
The code review part resonates a lot with me. Nothing scares me away more quickly than a pull request with no description, tests failing (or worse, no tests), no ticket/issue ID linked to it, etc.
The person opening the pull request is shifting the burden onto you to figure out what needs to be done and why. I believe this isn’t done in bad faith; it’s a matter of educating coworkers about boundaries for effective collaboration.
My principle is simple: I wouldn’t ask you to do something I wouldn’t do myself.